Commit 45fa9f97 authored by Yu Kuai's avatar Yu Kuai Committed by Jens Axboe
Browse files

lib/sbitmap: make sbitmap_get_shallow() internal 



Because it's only used in sbitmap.c

Signed-off-by: default avatarYu Kuai <yukuai3@huawei.com>
Reviewed-by: default avatarDamien Le Moal <dlemoal@kernel.org>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Reviewed-by: default avatarBart Van Assche <bvanassche@acm.org>
Link: https://lore.kernel.org/r/20250807032413.1469456-3-yukuai1@huaweicloud.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 42e6c6ce

include/linux/sbitmap.h

+0 −17
Original line number Diff line number Diff line
@@ -209,23 +209,6 @@ void sbitmap_resize(struct sbitmap *sb, unsigned int depth); 
 */

int sbitmap_get(struct sbitmap *sb);



/**

 * sbitmap_get_shallow() - Try to allocate a free bit from a &struct sbitmap,

 * limiting the depth used from each word.

 * @sb: Bitmap to allocate from.

 * @shallow_depth: The maximum number of bits to allocate from the bitmap.

 *

 * This rather specific operation allows for having multiple users with

 * different allocation limits. E.g., there can be a high-priority class that

 * uses sbitmap_get() and a low-priority class that uses sbitmap_get_shallow()

 * with a @shallow_depth of (sb->depth >> 1). Then, the low-priority

 * class can only allocate half of the total bits in the bitmap, preventing it

 * from starving out the high-priority class.

 *

 * Return: Non-negative allocated bit number if successful, -1 otherwise.

 */

int sbitmap_get_shallow(struct sbitmap *sb, unsigned long shallow_depth);



/**

 * sbitmap_any_bit_set() - Check for a set bit in a &struct sbitmap.

 * @sb: Bitmap to check.

lib/sbitmap.c

+16 −2
Original line number Diff line number Diff line
@@ -307,7 +307,22 @@ static int __sbitmap_get_shallow(struct sbitmap *sb, 
	return sbitmap_find_bit(sb, shallow_depth, index, alloc_hint, true);

}



int sbitmap_get_shallow(struct sbitmap *sb, unsigned long shallow_depth)

/**

 * sbitmap_get_shallow() - Try to allocate a free bit from a &struct sbitmap,

 * limiting the depth used from each word.

 * @sb: Bitmap to allocate from.

 * @shallow_depth: The maximum number of bits to allocate from the bitmap.

 *

 * This rather specific operation allows for having multiple users with

 * different allocation limits. E.g., there can be a high-priority class that

 * uses sbitmap_get() and a low-priority class that uses sbitmap_get_shallow()

 * with a @shallow_depth of (sb->depth >> 1). Then, the low-priority

 * class can only allocate half of the total bits in the bitmap, preventing it

 * from starving out the high-priority class.

 *

 * Return: Non-negative allocated bit number if successful, -1 otherwise.

 */

static int sbitmap_get_shallow(struct sbitmap *sb, unsigned long shallow_depth)

{

	int nr;

	unsigned int hint, depth;
@@ -322,7 +337,6 @@ int sbitmap_get_shallow(struct sbitmap *sb, unsigned long shallow_depth) 


	return nr;

}

EXPORT_SYMBOL_GPL(sbitmap_get_shallow);



bool sbitmap_any_bit_set(const struct sbitmap *sb)

{