Commit 46186667 authored by Lang Yu's avatar Lang Yu Committed by Alex Deucher
Browse files

drm/amdgpu: refine error handling in amdgpu_ttm_tt_pin_userptr 



Free sg table when dma_map_sgtable() failed to avoid memory leak.

Signed-off-by: default avatarLang Yu <lang.yu@amd.com>
Reviewed-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent d37bc6a4

drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c

+3 −1
Original line number Diff line number Diff line
@@ -812,7 +812,7 @@ static int amdgpu_ttm_tt_pin_userptr(struct ttm_device *bdev, 
	/* Map SG to device */

	r = dma_map_sgtable(adev->dev, ttm->sg, direction, 0);

	if (r)

		goto release_sg;

		goto release_sg_table;



	/* convert SG to linear array of pages and dma addresses */

	drm_prime_sg_to_dma_addr_array(ttm->sg, gtt->ttm.dma_address,
@@ -820,6 +820,8 @@ static int amdgpu_ttm_tt_pin_userptr(struct ttm_device *bdev, 


	return 0;



release_sg_table:

	sg_free_table(ttm->sg);

release_sg:

	kfree(ttm->sg);

	ttm->sg = NULL;