Commit 46447367 authored by Jens Axboe's avatar Jens Axboe
Browse files

io_uring/cmd_net: fix wrong argument types for skb_queue_splice() 



If timestamp retriving needs to be retried and the local list of
SKB's already has entries, then it's spliced back into the socket
queue. However, the arguments for the splice helper are transposed,
causing exactly the wrong direction of splicing into the on-stack
list. Fix that up.

Cc: stable@vger.kernel.org
Reported-by: default avatarGoogle Big Sleep <big-sleep-vuln-reports+bigsleep-462435176@google.com>
Fixes: 9e4ed359 ("io_uring/netcmd: add tx timestamping cmd support")
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 2d0e88f3

io_uring/cmd_net.c

+1 −1
Original line number Diff line number Diff line
@@ -127,7 +127,7 @@ static int io_uring_cmd_timestamp(struct socket *sock, 


	if (!unlikely(skb_queue_empty(&list))) {

		scoped_guard(spinlock_irqsave, &q->lock)

			skb_queue_splice(q, &list);

			skb_queue_splice(&list, q);

	}

	return -EAGAIN;

}