Commit 4644db83 authored by Hans Zhang's avatar Hans Zhang Committed by Bjorn Helgaas
Browse files

misc: pci_endpoint_test: Remove redundant 'remainder' test 

A BAR size is always a power of two. buf_size = min(SZ_1M, bar_size).
If the BAR size is <= 1MB, there will be one iteration, no remainder.
If the BAR size is > 1MB, there will be more than one iteration, but the
size will always be evenly divisible by 1MB, so no remainder.

Link: https://lore.kernel.org/r/20250109094556.1724663-2-18255117159@163.com


Suggested-by: default avatarNiklas Cassel <cassel@kernel.org>
Signed-off-by: default avatarHans Zhang <18255117159@163.com>
Signed-off-by: default avatarKrzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Reviewed-by: default avatarNiklas Cassel <cassel@kernel.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
parent d6658d33

drivers/misc/pci_endpoint_test.c

+1 −7
Original line number Diff line number Diff line
@@ -283,7 +283,7 @@ static int pci_endpoint_test_bar_memcmp(struct pci_endpoint_test *test, 
static bool pci_endpoint_test_bar(struct pci_endpoint_test *test,

				  enum pci_barno barno)

{

	int j, bar_size, buf_size, iters, remain;

	int j, bar_size, buf_size, iters;

	void *write_buf __free(kfree) = NULL;

	void *read_buf __free(kfree) = NULL;

	struct pci_dev *pdev = test->pdev;
@@ -316,12 +316,6 @@ static bool pci_endpoint_test_bar(struct pci_endpoint_test *test, 
						 write_buf, read_buf, buf_size))

			return false;



	remain = bar_size % buf_size;

	if (remain)

		if (pci_endpoint_test_bar_memcmp(test, barno, buf_size * iters,

						 write_buf, read_buf, remain))

			return false;



	return true;

}