Commit 4648fb2f authored by Larysa Zaremba's avatar Larysa Zaremba Committed by Tony Nguyen
Browse files

idpf: fix aux device unplugging when rdma is not supported by vport 



If vport flags do not contain VIRTCHNL2_VPORT_ENABLE_RDMA, driver does not
allocate vdev_info for this vport. This leads to kernel NULL pointer
dereference in idpf_idc_vport_dev_down(), which references vdev_info for
every vport regardless.

Check, if vdev_info was ever allocated before unplugging aux device.

Fixes: be91128c ("idpf: implement RDMA vport auxiliary dev create, init, and destroy")
Reviewed-by: default avatarMadhu Chittim <madhu.chittim@intel.com>
Signed-off-by: default avatarLarysa Zaremba <larysa.zaremba@intel.com>
Reviewed-by: default avatarPaul Menzel <pmenzel@molgen.mpg.de>
Reviewed-by: default avatarAleksandr Loktionov <aleksandr.loktionov@intel.com>
Tested-by: default avatarKrishneil Singh <krishneil.k.singh@intel.com>
Signed-off-by: default avatarTony Nguyen <anthony.l.nguyen@intel.com>
parent 086efe0a

drivers/net/ethernet/intel/idpf/idpf_idc.c

+1 −1
Original line number Diff line number Diff line
@@ -322,7 +322,7 @@ static void idpf_idc_vport_dev_down(struct idpf_adapter *adapter) 
	for (i = 0; i < adapter->num_alloc_vports; i++) {

		struct idpf_vport *vport = adapter->vports[i];



		if (!vport)

		if (!vport || !vport->vdev_info)

			continue;



		idpf_unplug_aux_dev(vport->vdev_info->adev);