Commit 464b99e7 authored by Matthieu Baerts (NGI0)'s avatar Matthieu Baerts (NGI0) Committed by Jakub Kicinski
Browse files

selftests: mptcp: lib: fix shellcheck errors 



It looks like we missed these two errors recently:

  - SC2068: Double quote array expansions to avoid re-splitting elements.
  - SC2145: Argument mixes string and array. Use * or separate argument.

Two simple fixes, it is not supposed to change the behaviour as the
variable names should not have any spaces in their names. Still, better
to fix them to easily spot new issues.

Fixes: f265d311 ("selftests: mptcp: lib: use setup/cleanup_ns helpers")
Signed-off-by: default avatarMatthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240712-upstream-net-next-20240712-selftests-mptcp-fix-shellcheck-v1-1-1cb7180db40a@kernel.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 22767eec

tools/testing/selftests/net/mptcp/mptcp_lib.sh

+2 −2
Original line number Diff line number Diff line
@@ -428,8 +428,8 @@ mptcp_lib_check_tools() { 
}



mptcp_lib_ns_init() {

	if ! setup_ns ${@}; then

		mptcp_lib_pr_fail "Failed to setup namespace ${@}"

	if ! setup_ns "${@}"; then

		mptcp_lib_pr_fail "Failed to setup namespaces ${*}"

		exit ${KSFT_FAIL}

	fi