Commit 4697381b authored by Jakub Kicinski's avatar Jakub Kicinski Committed by Paolo Abeni
Browse files

selftests: netdevsim: correct expected FEC strings 



ethtool CLI has changed its output. Make the test compatible.

Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Link: https://lore.kernel.org/r/20240114224748.1210578-1-kuba@kernel.org


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 2c4ca797

tools/testing/selftests/drivers/net/netdevsim/ethtool-fec.sh

+11 −7
Original line number Diff line number Diff line
@@ -8,16 +8,20 @@ NSIM_NETDEV=$(make_netdev) 


set -o pipefail



# Since commit 2b3ddcb35357 ("ethtool: fec: Change the prompt ...")

# in ethtool CLI the Configured lines start with Supported/Configured.

configured=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2 | head -1 | cut -d' ' -f1)



# netdevsim starts out with None/None

s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2)

check $? "$s" "Configured FEC encodings: None

check $? "$s" "$configured FEC encodings: None

Active FEC encoding: None"



# Test Auto

$ETHTOOL --set-fec $NSIM_NETDEV encoding auto

check $?

s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2)

check $? "$s" "Configured FEC encodings: Auto

check $? "$s" "$configured FEC encodings: Auto

Active FEC encoding: Off"



# Test case in-sensitivity
@@ -25,7 +29,7 @@ for o in off Off OFF; do 
    $ETHTOOL --set-fec $NSIM_NETDEV encoding $o

    check $?

    s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2)

    check $? "$s" "Configured FEC encodings: Off

    check $? "$s" "$configured FEC encodings: Off

Active FEC encoding: Off"

done
@@ -33,7 +37,7 @@ for o in BaseR baser BAser; do 
    $ETHTOOL --set-fec $NSIM_NETDEV encoding $o

    check $?

    s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2)

    check $? "$s" "Configured FEC encodings: BaseR

    check $? "$s" "$configured FEC encodings: BaseR

Active FEC encoding: BaseR"

done
@@ -41,7 +45,7 @@ for o in llrs rs; do 
    $ETHTOOL --set-fec $NSIM_NETDEV encoding $o

    check $?

    s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2)

    check $? "$s" "Configured FEC encodings: ${o^^}

    check $? "$s" "$configured FEC encodings: ${o^^}

Active FEC encoding: ${o^^}"

done
@@ -49,13 +53,13 @@ done 
$ETHTOOL --set-fec $NSIM_NETDEV encoding rs llrs

check $?

s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2)

check $? "$s" "Configured FEC encodings: RS LLRS

check $? "$s" "$configured FEC encodings: RS LLRS

Active FEC encoding: LLRS"



$ETHTOOL --set-fec $NSIM_NETDEV encoding rs off auto

check $?

s=$($ETHTOOL --show-fec $NSIM_NETDEV | tail -2)

check $? "$s" "Configured FEC encodings: Auto Off RS

check $? "$s" "$configured FEC encodings: Auto Off RS

Active FEC encoding: RS"



# Make sure other link modes are rejected