Commit 46a93917 authored by Christophe JAILLET's avatar Christophe JAILLET Committed by Jason Gunthorpe
Browse files

iommufd: Constify struct dma_buf_attach_ops 

'struct dma_buf_attach_ops' is not modified in this driver.

Constifying this structure moves some data to a read-only section, so
increases overall security, especially when the structure holds some
function pointers.

On a x86_64, with allmodconfig:
Before:
======
   text	   data	    bss	    dec	    hex	filename
  81096	  13899	    192	  95187	  173d3	drivers/iommu/iommufd/pages.o

After:
=====
   text	   data	    bss	    dec	    hex	filename
  81160	  13835	    192	  95187	  173d3	drivers/iommu/iommufd/pages.o

Link: https://patch.msgid.link/r/67e9126bbffa1d5c05124773a8dd4a3493be77ac.1772139886.git.christophe.jaillet@wanadoo.fr


Signed-off-by: default avatarChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 11439c46

drivers/iommu/iommufd/pages.c

+1 −1
Original line number Diff line number Diff line
@@ -1450,7 +1450,7 @@ static void iopt_revoke_notify(struct dma_buf_attachment *attach) 
	pages->dmabuf.phys.len = 0;

}



static struct dma_buf_attach_ops iopt_dmabuf_attach_revoke_ops = {

static const struct dma_buf_attach_ops iopt_dmabuf_attach_revoke_ops = {

	.allow_peer2peer = true,

	.move_notify = iopt_revoke_notify,

};