Commit 46bcb0a1 authored by Colin Ian King's avatar Colin Ian King Committed by Thomas Hellström
Browse files

drm/xe/guc: Fix inverted logic on snapshot->copy check 



Currently the check to see if snapshot->copy has been allocated is
inverted and ends up dereferencing snapshot->copy when free'ing
objects in the array when it is null or not free'ing the objects
when snapshot->copy is allocated. Fix this by using the correct
non-null pointer check logic.

Fixes: d8ce1a97 ("drm/xe/guc: Use a two stage dump for GuC logs and add more info")
Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Reviewed-by: default avatarJohn Harrison <John.C.Harrison@Intel.com>
Signed-off-by: default avatarThomas Hellström <thomas.hellstrom@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20241009160510.372195-1-colin.i.king@gmail.com
parent a187c1b0

drivers/gpu/drm/xe/xe_guc_log.c

+1 −1
Original line number Diff line number Diff line
@@ -122,7 +122,7 @@ void xe_guc_log_snapshot_free(struct xe_guc_log_snapshot *snapshot) 
	if (!snapshot)

		return;



	if (!snapshot->copy) {

	if (snapshot->copy) {

		for (i = 0; i < snapshot->num_chunks; i++)

			kfree(snapshot->copy[i]);

		kfree(snapshot->copy);