Commit 46e0ccfb authored by Radu Rendec's avatar Radu Rendec Committed by Jakub Kicinski
Browse files

net: vxlan: rename SKB_DROP_REASON_VXLAN_NO_REMOTE 



The SKB_DROP_REASON_VXLAN_NO_REMOTE skb drop reason was introduced in
the specific context of vxlan. As it turns out, there are similar cases
when a packet needs to be dropped in other parts of the network stack,
such as the bridge module.

Rename SKB_DROP_REASON_VXLAN_NO_REMOTE and give it a more generic name,
so that it can be used in other parts of the network stack. This is not
a functional change, and the numeric value of the drop reason even
remains unchanged.

Signed-off-by: default avatarRadu Rendec <rrendec@redhat.com>
Reviewed-by: default avatarIdo Schimmel <idosch@nvidia.com>
Acked-by: default avatarNikolay Aleksandrov <razor@blackwall.org>
Link: https://patch.msgid.link/20241219163606.717758-2-rrendec@redhat.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 6ad7f719

drivers/net/vxlan/vxlan_core.c

+2 −2
Original line number Diff line number Diff line
@@ -2798,7 +2798,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev) 
			dev_dstats_tx_dropped(dev);

			vxlan_vnifilter_count(vxlan, vni, NULL,

					      VXLAN_VNI_STATS_TX_DROPS, 0);

			kfree_skb_reason(skb, SKB_DROP_REASON_VXLAN_NO_REMOTE);

			kfree_skb_reason(skb, SKB_DROP_REASON_NO_TX_TARGET);

			return NETDEV_TX_OK;

		}

	}
@@ -2821,7 +2821,7 @@ static netdev_tx_t vxlan_xmit(struct sk_buff *skb, struct net_device *dev) 
		if (fdst)

			vxlan_xmit_one(skb, dev, vni, fdst, did_rsc);

		else

			kfree_skb_reason(skb, SKB_DROP_REASON_VXLAN_NO_REMOTE);

			kfree_skb_reason(skb, SKB_DROP_REASON_NO_TX_TARGET);

	}



	return NETDEV_TX_OK;

drivers/net/vxlan/vxlan_mdb.c

+1 −1
Original line number Diff line number Diff line
@@ -1712,7 +1712,7 @@ netdev_tx_t vxlan_mdb_xmit(struct vxlan_dev *vxlan, 
		vxlan_xmit_one(skb, vxlan->dev, src_vni,

			       rcu_dereference(fremote->rd), false);

	else

		kfree_skb_reason(skb, SKB_DROP_REASON_VXLAN_NO_REMOTE);

		kfree_skb_reason(skb, SKB_DROP_REASON_NO_TX_TARGET);



	return NETDEV_TX_OK;

}

include/net/dropreason-core.h

+3 −3
Original line number Diff line number Diff line
@@ -106,7 +106,7 @@ 
	FN(VXLAN_VNI_NOT_FOUND)		\

	FN(MAC_INVALID_SOURCE)		\

	FN(VXLAN_ENTRY_EXISTS)		\

	FN(VXLAN_NO_REMOTE)		\

	FN(NO_TX_TARGET)		\

	FN(IP_TUNNEL_ECN)		\

	FN(TUNNEL_TXINFO)		\

	FN(LOCAL_MAC)			\
@@ -497,8 +497,8 @@ enum skb_drop_reason { 
	 * entry or an entry pointing to a nexthop.

	 */

	SKB_DROP_REASON_VXLAN_ENTRY_EXISTS,

	/** @SKB_DROP_REASON_VXLAN_NO_REMOTE: no remote found for xmit */

	SKB_DROP_REASON_VXLAN_NO_REMOTE,

	/** @SKB_DROP_REASON_NO_TX_TARGET: no target found for xmit */

	SKB_DROP_REASON_NO_TX_TARGET,

	/**

	 * @SKB_DROP_REASON_IP_TUNNEL_ECN: skb is dropped according to

	 * RFC 6040 4.2, see __INET_ECN_decapsulate() for detail.