Commit 46ff4d11 authored by Thomas Gleixner's avatar Thomas Gleixner
Browse files

genirq/chip: Rework irq_set_chip() 



Use the new guards to get and lock the interrupt descriptor and tidy up the
code.

Fixup the kernel doc comment while at it.

No functional change.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Acked-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/all/20250429065421.295400891@linutronix.de
parent e7c65425

kernel/irq/chip.c

+12 −16
Original line number Diff line number Diff line
@@ -40,20 +40,16 @@ struct irqaction chained_action = { 
 */

int irq_set_chip(unsigned int irq, const struct irq_chip *chip)

{

	unsigned long flags;

	struct irq_desc *desc = irq_get_desc_lock(irq, &flags, 0);



	if (!desc)

		return -EINVAL;

	int ret = -EINVAL;



	desc->irq_data.chip = (struct irq_chip *)(chip ?: &no_irq_chip);

	irq_put_desc_unlock(desc, flags);

	/*

	 * For !CONFIG_SPARSE_IRQ make the irq show up in

	 * allocated_irqs.

	 */

	scoped_irqdesc_get_and_lock(irq, 0) {

		scoped_irqdesc->irq_data.chip = (struct irq_chip *)(chip ?: &no_irq_chip);

		ret = 0;

	}

	/* For !CONFIG_SPARSE_IRQ make the irq show up in allocated_irqs. */

	if (!ret)

		irq_mark_irq(irq);

	return 0;

	return ret;

}

EXPORT_SYMBOL(irq_set_chip);