Commit 4701ee50 authored by Alok Tiwari's avatar Alok Tiwari Committed by Jakub Kicinski
Browse files

be2net: Use correct byte order and format string for TCP seq and ack_seq 



The TCP header fields seq and ack_seq are 32-bit values in network
byte order as (__be32). these fields were earlier printed using
ntohs(), which converts only 16-bit values and produces incorrect
results for 32-bit fields. This patch is changeing the conversion
to ntohl(), ensuring correct interpretation of these sequence numbers.

Notably, the format specifier is updated from %d to %u to reflect the
unsigned nature of these fields.

improves the accuracy of debug log messages for TCP sequence and
acknowledgment numbers during TX timeouts.

Signed-off-by: default avatarAlok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250717193552.3648791-1-alok.a.tiwari@oracle.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 190ccb81

drivers/net/ethernet/emulex/benet/be_main.c

+4 −4
Original line number Diff line number Diff line
@@ -1465,10 +1465,10 @@ static void be_tx_timeout(struct net_device *netdev, unsigned int txqueue) 
						 ntohs(tcphdr->source));

					dev_info(dev, "TCP dest port %d\n",

						 ntohs(tcphdr->dest));

					dev_info(dev, "TCP sequence num %d\n",

						 ntohs(tcphdr->seq));

					dev_info(dev, "TCP ack_seq %d\n",

						 ntohs(tcphdr->ack_seq));

					dev_info(dev, "TCP sequence num %u\n",

						 ntohl(tcphdr->seq));

					dev_info(dev, "TCP ack_seq %u\n",

						 ntohl(tcphdr->ack_seq));

				} else if (ip_hdr(skb)->protocol ==

					   IPPROTO_UDP) {

					udphdr = udp_hdr(skb);