Unverified Commit 4703b014 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mark Brown
Browse files

ASoC: cs35l56: fix reversed if statement in cs35l56_dspwait_asp1tx_put() 



It looks like the "!" character was added accidentally.  The
regmap_update_bits_check() function is normally going to succeed.  This
means the rest of the function is unreachable and we don't handle the
situation where "changed" is true correctly.

Fixes: 07f7d6e7 ("ASoC: cs35l56: Fix for initializing ASP1 mixer registers")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarRichard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/0c254c07-d1c0-4a5c-a22b-7e135cab032c@moroto.mountain


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent e81fdba0

sound/soc/codecs/cs35l56.c

+1 −1
Original line number Diff line number Diff line
@@ -115,7 +115,7 @@ static int cs35l56_dspwait_asp1tx_put(struct snd_kcontrol *kcontrol, 


	ret = regmap_update_bits_check(cs35l56->base.regmap, addr,

				       CS35L56_ASP_TXn_SRC_MASK, val, &changed);

	if (!ret)

	if (ret)

		return ret;



	if (changed)