Commit 470cb09a authored by Dan Carpenter's avatar Dan Carpenter Committed by Simon Ser
Browse files

drm/plane: Fix IS_ERR() vs NULL bug drm_plane_create_color_pipeline_property() 



The drm_property_create_enum() function returns NULL on error, it never
returns error pointers.  Fix the error checking to match.

Fixes: 2afc3184 ("drm/plane: Add COLOR PIPELINE property")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: default avatarSimon Ser <contact@emersion.fr>
Link: https://patch.msgid.link/aTK9ZR0sMgqSACow@stanley.mountain
parent 1b3d18de

drivers/gpu/drm/drm_plane.c

+2 −2
Original line number Diff line number Diff line
@@ -1867,9 +1867,9 @@ int drm_plane_create_color_pipeline_property(struct drm_plane *plane, 
	prop = drm_property_create_enum(plane->dev, DRM_MODE_PROP_ATOMIC,

					"COLOR_PIPELINE",

					all_pipelines, len);

	if (IS_ERR(prop)) {

	if (!prop) {

		kfree(all_pipelines);

		return PTR_ERR(prop);

		return -ENOMEM;

	}



	drm_object_attach_property(&plane->base, prop, 0);