Commit 47210072 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Georgi Djakov
Browse files

dt-bindings: interconnect: qcom,sa8775p-rpmh: Fix incorrectly added reg and clocks



Commit 8a55fbe4 ("dt-bindings: interconnect: add reg and clocks
properties to enable QoS on sa8775p") claims that all interconnects have
clocks and MMIO address space, but that is just not true.  Only few
have.  Bindings should restrict properties and should not allow
specifying non-existing hardware description, so fix missing constraints
for 'reg' and 'clocks'.

Fixes: 8a55fbe4 ("dt-bindings: interconnect: add reg and clocks properties to enable QoS on sa8775p")
Signed-off-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: default avatarRob Herring (Arm) <robh@kernel.org>
Link: https://lore.kernel.org/r/20251129094612.16838-2-krzysztof.kozlowski@oss.qualcomm.com


Signed-off-by: default avatarGeorgi Djakov <djakov@kernel.org>
parent 8f0b4cce
Loading
Loading
Loading
Loading
+31 −0
Original line number Diff line number Diff line
@@ -74,6 +74,37 @@ allOf:
            - description: aggre UFS CARD AXI clock
            - description: RPMH CC IPA clock

  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,sa8775p-config-noc
              - qcom,sa8775p-dc-noc
              - qcom,sa8775p-gem-noc
              - qcom,sa8775p-gpdsp-anoc
              - qcom,sa8775p-lpass-ag-noc
              - qcom,sa8775p-mmss-noc
              - qcom,sa8775p-nspa-noc
              - qcom,sa8775p-nspb-noc
              - qcom,sa8775p-pcie-anoc
              - qcom,sa8775p-system-noc
    then:
      properties:
        clocks: false

  - if:
      properties:
        compatible:
          contains:
            enum:
              - qcom,sa8775p-clk-virt
              - qcom,sa8775p-mc-virt
    then:
      properties:
        reg: false
        clocks: false

unevaluatedProperties: false

examples: