Commit 473c3712 authored by Zhaoyang Huang's avatar Zhaoyang Huang Committed by Andrew Morton
Browse files

mm: migrate LRU_REFS_MASK bits in folio_migrate_flags 

Bits of LRU_REFS_MASK are not inherited during migration which lead to new
folio start from tier0 when MGLRU enabled.  Try to bring as much bits of
folio->flags as possible since compaction and alloc_contig_range which
introduce migration do happen at times.

Link: https://lkml.kernel.org/r/20240926050647.5653-1-zhaoyang.huang@unisoc.com


Signed-off-by: default avatarZhaoyang Huang <zhaoyang.huang@unisoc.com>
Suggested-by: default avatarYu Zhao <yuzhao@google.com>
Acked-by: default avatarDavid Hildenbrand <david@redhat.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Yu Zhao <yuzhao@google.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 583e66de

include/linux/mm_inline.h

+10 −0
Original line number Diff line number Diff line
@@ -291,6 +291,12 @@ static inline bool lru_gen_del_folio(struct lruvec *lruvec, struct folio *folio, 
	return true;

}



static inline void folio_migrate_refs(struct folio *new, struct folio *old)

{

	unsigned long refs = READ_ONCE(old->flags) & LRU_REFS_MASK;



	set_mask_bits(&new->flags, LRU_REFS_MASK, refs);

}

#else /* !CONFIG_LRU_GEN */



static inline bool lru_gen_enabled(void)
@@ -313,6 +319,10 @@ static inline bool lru_gen_del_folio(struct lruvec *lruvec, struct folio *folio, 
	return false;

}



static inline void folio_migrate_refs(struct folio *new, struct folio *old)

{



}

#endif /* CONFIG_LRU_GEN */



static __always_inline

mm/migrate.c

+1 −0
Original line number Diff line number Diff line
@@ -695,6 +695,7 @@ void folio_migrate_flags(struct folio *newfolio, struct folio *folio) 
	if (folio_test_idle(folio))

		folio_set_idle(newfolio);



	folio_migrate_refs(newfolio, folio);

	/*

	 * Copy NUMA information to the new page, to prevent over-eager

	 * future migrations of this same page.