Commit 4754affe authored by Nicolas Dichtel's avatar Nicolas Dichtel Committed by Paolo Abeni
Browse files

net: advertise netns_immutable property via netlink 



Since commit 05c1280a ("netdev_features: convert NETIF_F_NETNS_LOCAL to
dev->netns_local"), there is no way to see if the netns_immutable property
s set on a device. Let's add a netlink attribute to advertise it.

Signed-off-by: default avatarNicolas Dichtel <nicolas.dichtel@6wind.com>
Reviewed-by: default avatarEric Dumazet <edumazet@google.com>
Reviewed-by: default avatarAlexander Lobakin <aleksander.lobakin@intel.com>
Reviewed-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 0c493da8

Documentation/netlink/specs/rt_link.yaml

+3 −0
Original line number Diff line number Diff line
@@ -1160,6 +1160,9 @@ attribute-sets: 
        name: max-pacing-offload-horizon

        type: uint

        doc: EDT offload horizon supported by the device (in nsec).

      -

        name: netns-immutable

        type: u8

  -

    name: af-spec-attrs

    attributes:

include/uapi/linux/if_link.h

+1 −0
Original line number Diff line number Diff line
@@ -378,6 +378,7 @@ enum { 
	IFLA_GRO_IPV4_MAX_SIZE,

	IFLA_DPLL_PIN,

	IFLA_MAX_PACING_OFFLOAD_HORIZON,

	IFLA_NETNS_IMMUTABLE,

	__IFLA_MAX

};

net/core/rtnetlink.c

+3 −0
Original line number Diff line number Diff line
@@ -1292,6 +1292,7 @@ static noinline size_t if_nlmsg_size(const struct net_device *dev, 
	       + nla_total_size(4) /* IFLA_TSO_MAX_SEGS */

	       + nla_total_size(1) /* IFLA_OPERSTATE */

	       + nla_total_size(1) /* IFLA_LINKMODE */

	       + nla_total_size(1) /* IFLA_NETNS_IMMUTABLE */

	       + nla_total_size(4) /* IFLA_CARRIER_CHANGES */

	       + nla_total_size(4) /* IFLA_LINK_NETNSID */

	       + nla_total_size(4) /* IFLA_GROUP */
@@ -2046,6 +2047,7 @@ static int rtnl_fill_ifinfo(struct sk_buff *skb, 
		       netif_running(dev) ? READ_ONCE(dev->operstate) :

					    IF_OPER_DOWN) ||

	    nla_put_u8(skb, IFLA_LINKMODE, READ_ONCE(dev->link_mode)) ||

	    nla_put_u8(skb, IFLA_NETNS_IMMUTABLE, dev->netns_immutable) ||

	    nla_put_u32(skb, IFLA_MTU, READ_ONCE(dev->mtu)) ||

	    nla_put_u32(skb, IFLA_MIN_MTU, READ_ONCE(dev->min_mtu)) ||

	    nla_put_u32(skb, IFLA_MAX_MTU, READ_ONCE(dev->max_mtu)) ||
@@ -2234,6 +2236,7 @@ static const struct nla_policy ifla_policy[IFLA_MAX+1] = { 
	[IFLA_ALLMULTI]		= { .type = NLA_REJECT },

	[IFLA_GSO_IPV4_MAX_SIZE]	= NLA_POLICY_MIN(NLA_U32, MAX_TCP_HEADER + 1),

	[IFLA_GRO_IPV4_MAX_SIZE]	= { .type = NLA_U32 },

	[IFLA_NETNS_IMMUTABLE]	= { .type = NLA_REJECT },

};



static const struct nla_policy ifla_info_policy[IFLA_INFO_MAX+1] = {