Commit 47558cba authored by Dan Carpenter's avatar Dan Carpenter Committed by Mathieu Poirier
Browse files

remoteproc: mediatek: Fix error code in scp_rproc_init() 



Set the error code to ERR_PTR(-ENOMEM).  Otherwise if there is an
allocation failure it leads to a NULL dereference in the caller.

Fixes: c08a8249 ("remoteproc: mediatek: Support setting DRAM and IPI shared buffer sizes")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarAngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/b2114e3c-fa64-4edb-a1ff-d2009e544c3f@moroto.mountain


Signed-off-by: default avatarMathieu Poirier <mathieu.poirier@linaro.org>
parent 3c8a9066

drivers/remoteproc/mtk_scp.c

+1 −0
Original line number Diff line number Diff line
@@ -1156,6 +1156,7 @@ static struct mtk_scp *scp_rproc_init(struct platform_device *pdev, 
	scp->share_buf = kzalloc(scp_sizes->ipi_share_buffer_size, GFP_KERNEL);

	if (!scp->share_buf) {

		dev_err(dev, "Failed to allocate IPI share buffer\n");

		ret = -ENOMEM;

		goto release_dev_mem;

	}