Commit 476688c8 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Carlos Maiolino
Browse files

xfs: remove the xfs_extent_t typedef 



There are almost no users of the typedef left, kill it and switch the
remaining users to use the underlying struct.

Also fix up the comment about the struct xfs_extent definition to be
correct and read more easily.

Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Reviewed-by: default avatarDarrick J. Wong <djwong@kernel.org>
Signed-off-by: default avatarCarlos Maiolino <cem@kernel.org>
parent 05f17dcb

fs/xfs/libxfs/xfs_log_format.h

+9 −8
Original line number Diff line number Diff line
@@ -605,16 +605,17 @@ xfs_blft_from_flags(struct xfs_buf_log_format *blf) 
/*

 * EFI/EFD log format definitions

 */

typedef struct xfs_extent {

struct xfs_extent {

	xfs_fsblock_t	ext_start;

	xfs_extlen_t	ext_len;

} xfs_extent_t;

};



/*

 * Since an xfs_extent_t has types (start:64, len: 32)

 * there are different alignments on 32 bit and 64 bit kernels.

 * So we provide the different variants for use by a

 * conversion routine.

 * Since the structures in struct xfs_extent add up to 96 bytes, it has

 * different alignments on i386 vs all other architectures, because i386

 * does not pad structures to their natural alignment.

 *

 * Provide the different variants for use by a conversion routine.

 */

typedef struct xfs_extent_32 {

	uint64_t	ext_start;
@@ -637,7 +638,7 @@ typedef struct xfs_efi_log_format { 
	uint16_t		efi_size;	/* size of this item */

	uint32_t		efi_nextents;	/* # extents to free */

	uint64_t		efi_id;		/* efi identifier */

	xfs_extent_t		efi_extents[];	/* array of extents to free */

	struct xfs_extent	efi_extents[];	/* array of extents to free */

} xfs_efi_log_format_t;



static inline size_t
@@ -690,7 +691,7 @@ typedef struct xfs_efd_log_format { 
	uint16_t		efd_size;	/* size of this item */

	uint32_t		efd_nextents;	/* # of extents freed */

	uint64_t		efd_efi_id;	/* id of corresponding efi */

	xfs_extent_t		efd_extents[];	/* array of extents freed */

	struct xfs_extent	efd_extents[];	/* array of extents freed */

} xfs_efd_log_format_t;



static inline size_t