Unverified Commit 47742484 authored by Samuel Holland's avatar Samuel Holland Committed by Palmer Dabbelt
Browse files

riscv: Remove extra variable in patch_text_nosync() 



This cast is superfluous, and is incorrect anyway if compressed
instructions may be present.

Reviewed-by: default avatarBjörn Töpel <bjorn@rivosinc.com>
Signed-off-by: default avatarSamuel Holland <samuel.holland@sifive.com>
Reviewed-by: default avatarConor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20240327160520.791322-8-samuel.holland@sifive.com


Signed-off-by: default avatarPalmer Dabbelt <palmer@rivosinc.com>
parent eaee5487

arch/riscv/kernel/patch.c

+4 −8
Original line number Diff line number Diff line
@@ -186,13 +186,11 @@ NOKPROBE_SYMBOL(patch_insn_set); 


int patch_text_set_nosync(void *addr, u8 c, size_t len)

{

	u32 *tp = addr;

	int ret;



	ret = patch_insn_set(tp, c, len);



	ret = patch_insn_set(addr, c, len);

	if (!ret)

		flush_icache_range((uintptr_t)tp, (uintptr_t)tp + len);

		flush_icache_range((uintptr_t)addr, (uintptr_t)addr + len);



	return ret;

}
@@ -224,13 +222,11 @@ NOKPROBE_SYMBOL(patch_insn_write); 


int patch_text_nosync(void *addr, const void *insns, size_t len)

{

	u32 *tp = addr;

	int ret;



	ret = patch_insn_write(tp, insns, len);



	ret = patch_insn_write(addr, insns, len);

	if (!ret)

		flush_icache_range((uintptr_t) tp, (uintptr_t) tp + len);

		flush_icache_range((uintptr_t)addr, (uintptr_t)addr + len);



	return ret;

}