Commit 477c200a authored by SkyLake.Huang's avatar SkyLake.Huang Committed by David S. Miller
Browse files

net: phy: mediatek: Improve readability of mtk-phy-lib.c's mtk_phy_led_hw_ctrl_set() 



This patch removes parens around TRIGGER_NETDEV_RX/TRIGGER_NETDEV_TX in
mtk_phy_led_hw_ctrl_set(), which improves readability.

Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarSkyLake.Huang <skylake.huang@mediatek.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7f9c320c

drivers/net/phy/mediatek/mtk-phy-lib.c

+24 −20
Original line number Diff line number Diff line
@@ -129,29 +129,33 @@ int mtk_phy_led_hw_ctrl_set(struct phy_device *phydev, u8 index, 
		on |= MTK_PHY_LED_ON_LINK2500;



	if (rules & BIT(TRIGGER_NETDEV_RX)) {

		blink |= (on & on_set) ?

			  (((on & MTK_PHY_LED_ON_LINK10) ?

			    MTK_PHY_LED_BLINK_10RX : 0) |

			   ((on & MTK_PHY_LED_ON_LINK100) ?

			    MTK_PHY_LED_BLINK_100RX : 0) |

			   ((on & MTK_PHY_LED_ON_LINK1000) ?

			    MTK_PHY_LED_BLINK_1000RX : 0) |

			   ((on & MTK_PHY_LED_ON_LINK2500) ?

			    MTK_PHY_LED_BLINK_2500RX : 0)) :

			  rx_blink_set;

		if (on & on_set) {

			if (on & MTK_PHY_LED_ON_LINK10)

				blink |= MTK_PHY_LED_BLINK_10RX;

			if (on & MTK_PHY_LED_ON_LINK100)

				blink |= MTK_PHY_LED_BLINK_100RX;

			if (on & MTK_PHY_LED_ON_LINK1000)

				blink |= MTK_PHY_LED_BLINK_1000RX;

			if (on & MTK_PHY_LED_ON_LINK2500)

				blink |= MTK_PHY_LED_BLINK_2500RX;

		} else {

			blink |= rx_blink_set;

		}

	}



	if (rules & BIT(TRIGGER_NETDEV_TX)) {

		blink |= (on & on_set) ?

			  (((on & MTK_PHY_LED_ON_LINK10) ?

			    MTK_PHY_LED_BLINK_10TX : 0) |

			   ((on & MTK_PHY_LED_ON_LINK100) ?

			    MTK_PHY_LED_BLINK_100TX : 0) |

			   ((on & MTK_PHY_LED_ON_LINK1000) ?

			    MTK_PHY_LED_BLINK_1000TX : 0) |

			   ((on & MTK_PHY_LED_ON_LINK2500) ?

			    MTK_PHY_LED_BLINK_2500TX : 0)) :

			  tx_blink_set;

		if (on & on_set) {

			if (on & MTK_PHY_LED_ON_LINK10)

				blink |= MTK_PHY_LED_BLINK_10TX;

			if (on & MTK_PHY_LED_ON_LINK100)

				blink |= MTK_PHY_LED_BLINK_100TX;

			if (on & MTK_PHY_LED_ON_LINK1000)

				blink |= MTK_PHY_LED_BLINK_1000TX;

			if (on & MTK_PHY_LED_ON_LINK2500)

				blink |= MTK_PHY_LED_BLINK_2500TX;

		} else {

			blink |= tx_blink_set;

		}

	}



	if (blink || on)