Commit 477c352a authored by Tariq Toukan's avatar Tariq Toukan Committed by Jakub Kicinski
Browse files

net/mlx5e: Do not re-apply TIR loopback configuration if not necessary 



On old firmware, (tis_tir_td_order=0), TIR of a transport domain should
either be created after all SQs of the same domain, or TIR.self_lb_en
should be reapplied using MODIFY_TIR, for self loopback filtering to
function correctly.

This is not necessary anymnore on new FW (tis_tir_td_order=1), thus
there's no need for calling modify_tir operations after creating a new
set of SQs to maintain the self loopback prevention functional.

Skip these operations.

This saves O(max_num_channels) MODIFY_TIR firmware commands in
operations like interface up or channels configuration change.

Signed-off-by: default avatarTariq Toukan <tariqt@nvidia.com>
Reviewed-by: default avatarCarolina Jubran <cjubran@nvidia.com>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://patch.msgid.link/1761831159-1013140-6-git-send-email-tariqt@nvidia.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent a4c81e72

drivers/net/ethernet/mellanox/mlx5/core/en_common.c

+3 −0
Original line number Diff line number Diff line
@@ -282,5 +282,8 @@ int mlx5e_modify_tirs_lb(struct mlx5_core_dev *mdev, bool enable_uc_lb, 
int mlx5e_refresh_tirs(struct mlx5_core_dev *mdev, bool enable_uc_lb,

		       bool enable_mc_lb)

{

	if (MLX5_CAP_GEN(mdev, tis_tir_td_order))

		return 0; /* refresh not needed */



	return mlx5e_modify_tirs_lb(mdev, enable_uc_lb, enable_mc_lb);

}