Unverified Commit 479acb9d authored by Dan Carpenter's avatar Dan Carpenter Committed by Maxime Ripard
Browse files

drm/plane: Fix IS_ERR() vs NULL check in drm_plane_create_hotspot_properties() 



The drm_property_create_signed_range() function doesn't return error
pointers it returns NULL on error.  Fix the error checking to match.

Fixes: 8f7179a1 ("drm/atomic: Add support for mouse hotspots")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarZack Rusin <zack.rusin@broadcom.com>
Link: https://patch.msgid.link/aTB023cfcIPkCsFS@stanley.mountain


Signed-off-by: default avatarMaxime Ripard <mripard@kernel.org>
parent 35e282c1

drivers/gpu/drm/drm_plane.c

+4 −4
Original line number Diff line number Diff line
@@ -338,14 +338,14 @@ static int drm_plane_create_hotspot_properties(struct drm_plane *plane) 


	prop_x = drm_property_create_signed_range(plane->dev, 0, "HOTSPOT_X",

						  INT_MIN, INT_MAX);

	if (IS_ERR(prop_x))

		return PTR_ERR(prop_x);

	if (!prop_x)

		return -ENOMEM;



	prop_y = drm_property_create_signed_range(plane->dev, 0, "HOTSPOT_Y",

						  INT_MIN, INT_MAX);

	if (IS_ERR(prop_y)) {

	if (!prop_y) {

		drm_property_destroy(plane->dev, prop_x);

		return PTR_ERR(prop_y);

		return -ENOMEM;

	}



	drm_object_attach_property(&plane->base, prop_x, 0);