Commit 47af06c9 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Thomas Gleixner
Browse files

genirq: Consistently use '%u' format specifier for unsigned int variables 



There are three cases in the genirq code when the irq, as an unsigned
integer variable, is converted to text representation by sprintf().
In two cases it uses '%d' specifier which is for signed values. While
it's not a problem right now, potentially it might be in the future
in case too big (> INT_MAX) number will appear there.

Consistently use '%u' format specifier for @irq which is declared as
unsigned int in all these cases.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/20250509154643.1499171-1-andriy.shevchenko@linux.intel.com
parent b5fcb689

kernel/irq/debugfs.c

+1 −1
Original line number Diff line number Diff line
@@ -230,7 +230,7 @@ void irq_add_debugfs_entry(unsigned int irq, struct irq_desc *desc) 
	if (!irq_dir || !desc || desc->debugfs_file)

		return;



	sprintf(name, "%d", irq);

	sprintf(name, "%u", irq);

	desc->debugfs_file = debugfs_create_file(name, 0644, irq_dir, desc,

						 &dfs_irq_ops);

}

kernel/irq/proc.c

+2 −2
Original line number Diff line number Diff line
@@ -345,7 +345,7 @@ void register_irq_proc(unsigned int irq, struct irq_desc *desc) 
		return;



	/* create /proc/irq/1234 */

	sprintf(name, "%d", irq);

	sprintf(name, "%u", irq);

	desc->dir = proc_mkdir(name, root_irq_dir);

	if (!desc->dir)

		return;