Commit 47c84997 authored by Hangbin Liu's avatar Hangbin Liu Committed by Jakub Kicinski
Browse files

selftests: net: lib: fix shift count out of range 



I got the following warning when writing other tests:

  + handle_test_result_pass 'bond 802.3ad' '(lacp_active off)'
  + local 'test_name=bond 802.3ad'
  + shift
  + local 'opt_str=(lacp_active off)'
  + shift
  + log_test_result 'bond 802.3ad' '(lacp_active off)' ' OK '
  + local 'test_name=bond 802.3ad'
  + shift
  + local 'opt_str=(lacp_active off)'
  + shift
  + local 'result= OK '
  + shift
  + local retmsg=
  + shift
  /net/tools/testing/selftests/net/forwarding/../lib.sh: line 315: shift: shift count out of range

This happens because an extra shift is executed even after all arguments
have been consumed. Remove the last shift in log_test_result() to avoid
this warning.

Fixes: a923af1c ("selftests: forwarding: Convert log_test() to recognize RET values")
Signed-off-by: default avatarHangbin Liu <liuhangbin@gmail.com>
Link: https://patch.msgid.link/20250709091244.88395-1-liuhangbin@gmail.com


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent ce913b22

tools/testing/selftests/net/lib.sh

+1 −1
Original line number Diff line number Diff line
@@ -312,7 +312,7 @@ log_test_result() 
	local test_name=$1; shift

	local opt_str=$1; shift

	local result=$1; shift

	local retmsg=$1; shift

	local retmsg=$1



	printf "TEST: %-60s  [%s]\n" "$test_name $opt_str" "$result"

	if [[ $retmsg ]]; then