Commit 47e8e9d2 authored by Antonio Quartulli's avatar Antonio Quartulli
Browse files

ovpn: fix ndo_start_xmit return value on error 



ndo_start_xmit is basically expected to always return NETDEV_TX_OK.
However, in case of error, it was currently returning NET_XMIT_DROP,
which is not a valid netdev_tx_t return value, leading to
misinterpretation.

Change ndo_start_xmit to always return NETDEV_TX_OK to signal back
to the caller that the packet was handled (even if dropped).

Effects of this bug can be seen when sending IPv6 packets having
no peer to forward them to:

  $ ip netns exec ovpn-server oping -c20 fd00:abcd:220:201::1
  PING fd00:abcd:220:201::1 (fd00:abcd:220:201::1) 56 bytes of data.00:abcd:220:201 :1
  ping_send failed: No buffer space available
  ping_sendto: No buffer space available
  ping_send failed: No buffer space available
  ping_sendto: No buffer space available
  ...

Fixes: c2d950c4 ("ovpn: add basic interface creation/destruction/management routines")
Reported-by: default avatarGert Doering <gert@greenie.muc.de>
Closes: https://github.com/OpenVPN/ovpn-net-next/issues/5


Tested-by: default avatarGert Doering <gert@greenie.muc.de>
Acked-by: default avatarGert Doering <gert@greenie.muc.de>
Link: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg31591.html


Signed-off-by: default avatarAntonio Quartulli <antonio@openvpn.net>
parent 8624daf9

drivers/net/ovpn/io.c

+1 −1
Original line number Diff line number Diff line
@@ -410,7 +410,7 @@ netdev_tx_t ovpn_net_xmit(struct sk_buff *skb, struct net_device *dev) 
	dev_dstats_tx_dropped(ovpn->dev);

	skb_tx_error(skb);

	kfree_skb_list(skb);

	return NET_XMIT_DROP;

	return NETDEV_TX_OK;

}



/**