Commit 47efbac9 authored by Ido Schimmel's avatar Ido Schimmel Committed by Paolo Abeni
Browse files

selftests: traceroute: Use require_command() 



Use require_command() so that the test will return SKIP (4) when a
required command is not present.

Before:

 # ./traceroute.sh
 SKIP: Could not run IPV6 test without traceroute6
 SKIP: Could not run IPV4 test without traceroute
 $ echo $?
 0

After:

 # ./traceroute.sh
 TEST: traceroute6 not installed                                    [SKIP]
 $ echo $?
 4

Reviewed-by: default avatarPetr Machata <petrm@nvidia.com>
Reviewed-by: default avatarDavid Ahern <dsahern@kernel.org>
Signed-off-by: default avatarIdo Schimmel <idosch@nvidia.com>
Link: https://patch.msgid.link/20250908073238.119240-6-idosch@nvidia.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent c068ba9d

tools/testing/selftests/net/traceroute.sh

+3 −10
Original line number Diff line number Diff line
@@ -181,11 +181,6 @@ setup_traceroute6() 


run_traceroute6()

{

	if [ ! -x "$(command -v traceroute6)" ]; then

		echo "SKIP: Could not run IPV6 test without traceroute6"

		return

	fi



	setup_traceroute6



	RET=0
@@ -249,11 +244,6 @@ setup_traceroute() 


run_traceroute()

{

	if [ ! -x "$(command -v traceroute)" ]; then

		echo "SKIP: Could not run IPV4 test without traceroute"

		return

	fi



	setup_traceroute



	RET=0
@@ -287,6 +277,9 @@ do 
	esac

done



require_command traceroute6

require_command traceroute



run_tests



exit "${EXIT_STATUS}"