Commit 481ec3b3 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Heiko Carstens
Browse files

s390/cio: use while (i--) pattern to clean up 



Use more natural while (i--) pattern to clean up allocated resources.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: default avatarVineeth Vijayan <vneethv@linux.ibm.com>
Link: https://lore.kernel.org/r/20240222134501.236871-1-andriy.shevchenko@linux.intel.com


Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
parent 69460c5e

drivers/s390/cio/ccwgroup.c

+2 −2
Original line number Diff line number Diff line
@@ -240,7 +240,7 @@ static int __ccwgroup_create_symlinks(struct ccwgroup_device *gdev) 
		rc = sysfs_create_link(&gdev->cdev[i]->dev.kobj,

				       &gdev->dev.kobj, "group_device");

		if (rc) {

			for (--i; i >= 0; i--)

			while (i--)

				sysfs_remove_link(&gdev->cdev[i]->dev.kobj,

						  "group_device");

			return rc;
@@ -251,7 +251,7 @@ static int __ccwgroup_create_symlinks(struct ccwgroup_device *gdev) 
		rc = sysfs_create_link(&gdev->dev.kobj,

				       &gdev->cdev[i]->dev.kobj, str);

		if (rc) {

			for (--i; i >= 0; i--) {

			while (i--) {

				sprintf(str, "cdev%d", i);

				sysfs_remove_link(&gdev->dev.kobj, str);

			}

drivers/s390/cio/chsc.c

+1 −1
Original line number Diff line number Diff line
@@ -844,7 +844,7 @@ chsc_add_cmg_attr(struct channel_subsystem *css) 
	}

	return ret;

cleanup:

	for (--i; i >= 0; i--) {

	while (i--) {

		if (!css->chps[i])

			continue;

		chp_remove_cmg_attr(css->chps[i]);