Commit 48233291 authored Oct 14, 2025 by Thomas Weißschuh Committed by Vlastimil Babka Nov 23, 2025

mempool: clarify behavior of mempool_alloc_preallocated()

The documentation of that function promises to never sleep.  However on
PREEMPT_RT a spinlock_t might in fact sleep.

Reword the documentation so users can predict its behavior better.

mempool could also replace spinlock_t with raw_spinlock_t which doesn't
sleep even on PREEMPT_RT but that would take away the improved
preemptibility of sleeping locks.

Link: https://lkml.kernel.org/r/20251014-mempool-doc-v1-1-bc9ebf169700@linutronix.de


Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Cc: Christoph Lameter <cl@gentwo.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Roman Gushchin <roman.gushchin@linux.dev>
Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Steven Rostedt <rostedt@goodmis.org>
Cc: "Vishal Moola (Oracle)" <vishal.moola@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Vlastimil Babka <vbabka@suse.cz>

parent 07723a41

mm/mempool.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -576,8 +576,8 @@ EXPORT_SYMBOL(mempool_alloc_noprof);
		* @pool: pointer to the memory pool
		*
		* This function is similar to mempool_alloc(), but it only attempts allocating
		* an element from the preallocated elements. It does not sleep and immediately
		* returns if no preallocated elements are available.
		* an element from the preallocated elements. It only takes a single spinlock_t
		* and immediately returns if no preallocated elements are available.
		*
		* Return: pointer to the allocated element or %NULL if no elements are
		* available.