Commit 482a483c authored by Nam Cao's avatar Nam Cao Committed by Thomas Gleixner
Browse files

drm/i915/request: Remove unnecessary modification of hrtimer:: Function 



When a request is created, the hrtimer is not initialized and only its
'function' field is set to NULL. The hrtimer is only initialized when the
request is enqueued. The point of setting 'function' to NULL is that, it
can be used to check whether hrtimer_try_to_cancel() should be called while
retiring the request.

This "trick" is unnecessary, because hrtimer_try_to_cancel() already does
its own check whether the timer is armed. If the timer is not armed,
hrtimer_try_to_cancel() returns 0.

Fully initialize the timer when the request is created, which allows to
make the hrtimer::function field private once all users of hrtimer_init()
are converted to hrtimer_setup(), which requires a valid callback function
to be set.

Because hrtimer_try_to_cancel() returns 0 if the timer is not armed, the
logic to check whether to call i915_request_put() remains equivalent.

Signed-off-by: default avatarNam Cao <namcao@linutronix.de>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/50f865045aa672a9730343ad131543da332b1d8d.1730386209.git.namcao@linutronix.de
parent fbf920f2

drivers/gpu/drm/i915/i915_request.c

+9 −8
Original line number Diff line number Diff line
@@ -273,11 +273,6 @@ i915_request_active_engine(struct i915_request *rq, 
	return ret;

}



static void __rq_init_watchdog(struct i915_request *rq)

{

	rq->watchdog.timer.function = NULL;

}



static enum hrtimer_restart __rq_watchdog_expired(struct hrtimer *hrtimer)

{

	struct i915_request *rq =
@@ -294,6 +289,14 @@ static enum hrtimer_restart __rq_watchdog_expired(struct hrtimer *hrtimer) 
	return HRTIMER_NORESTART;

}



static void __rq_init_watchdog(struct i915_request *rq)

{

	struct i915_request_watchdog *wdg = &rq->watchdog;



	hrtimer_init(&wdg->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);

	wdg->timer.function = __rq_watchdog_expired;

}



static void __rq_arm_watchdog(struct i915_request *rq)

{

	struct i915_request_watchdog *wdg = &rq->watchdog;
@@ -304,8 +307,6 @@ static void __rq_arm_watchdog(struct i915_request *rq) 


	i915_request_get(rq);



	hrtimer_init(&wdg->timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);

	wdg->timer.function = __rq_watchdog_expired;

	hrtimer_start_range_ns(&wdg->timer,

			       ns_to_ktime(ce->watchdog.timeout_us *

					   NSEC_PER_USEC),
@@ -317,7 +318,7 @@ static void __rq_cancel_watchdog(struct i915_request *rq) 
{

	struct i915_request_watchdog *wdg = &rq->watchdog;



	if (wdg->timer.function && hrtimer_try_to_cancel(&wdg->timer) > 0)

	if (hrtimer_try_to_cancel(&wdg->timer) > 0)

		i915_request_put(rq);

}