Commit 48388069 authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Wim Van Sebroeck
Browse files

watchdog: wdrtas: don't use custom version of print_hex_dump 



Kernel has nice helpers to dump buffers.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarWim Van Sebroeck <wim@iguana.be>
parent fcf95670

drivers/watchdog/wdrtas.c

+3 −26
Original line number Diff line number Diff line
@@ -161,31 +161,6 @@ static void wdrtas_timer_stop(void) 
	wdrtas_set_interval(0);

}



/**

 * wdrtas_log_scanned_event - logs an event we received during keepalive

 *

 * wdrtas_log_scanned_event prints a message to the log buffer dumping

 * the results of the last event-scan call

 */

static void wdrtas_log_scanned_event(void)

{

	int i;



	for (i = 0; i < WDRTAS_LOGBUFFER_LEN; i += 16)

		pr_info("dumping event (line %i/%i), data = "

			"%02x %02x %02x %02x  %02x %02x %02x %02x   "

			"%02x %02x %02x %02x  %02x %02x %02x %02x\n",

			(i / 16) + 1, (WDRTAS_LOGBUFFER_LEN / 16),

			wdrtas_logbuffer[i + 0], wdrtas_logbuffer[i + 1],

			wdrtas_logbuffer[i + 2], wdrtas_logbuffer[i + 3],

			wdrtas_logbuffer[i + 4], wdrtas_logbuffer[i + 5],

			wdrtas_logbuffer[i + 6], wdrtas_logbuffer[i + 7],

			wdrtas_logbuffer[i + 8], wdrtas_logbuffer[i + 9],

			wdrtas_logbuffer[i + 10], wdrtas_logbuffer[i + 11],

			wdrtas_logbuffer[i + 12], wdrtas_logbuffer[i + 13],

			wdrtas_logbuffer[i + 14], wdrtas_logbuffer[i + 15]);

}



/**

 * wdrtas_timer_keepalive - resets watchdog timer to keep system alive

 *
@@ -205,7 +180,9 @@ static void wdrtas_timer_keepalive(void) 
		if (result < 0)

			pr_err("event-scan failed: %li\n", result);

		if (result == 0)

			wdrtas_log_scanned_event();

			print_hex_dump(KERN_INFO, "dumping event, data: ",

				DUMP_PREFIX_OFFSET, 16, 1,

				wdrtas_logbuffer, WDRTAS_LOGBUFFER_LEN, false);

	} while (result == 0);

}