Commit 4854b463 authored by Breno Leitao's avatar Breno Leitao Committed by Jakub Kicinski
Browse files

net: dql: Avoid calling BUG() when WARN() is enough 



If the dql_queued() function receives an invalid argument, WARN about it
and continue, instead of crashing the kernel.

This was raised by checkpatch, when I am refactoring this code (see
following patch/commit)

	WARNING: Do not crash the kernel unless it is absolutely unavoidable--use WARN_ON_ONCE() plus recovery code (if feasible) instead of BUG() or variants

Signed-off-by: default avatarBreno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20240411192241.2498631-2-leitao@debian.org


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 444cde13

include/linux/dynamic_queue_limits.h

+2 −1
Original line number Diff line number Diff line
@@ -91,7 +91,8 @@ static inline void dql_queued(struct dql *dql, unsigned int count) 
{

	unsigned long map, now, now_hi, i;



	BUG_ON(count > DQL_MAX_OBJECT);

	if (WARN_ON_ONCE(count > DQL_MAX_OBJECT))

		return;



	dql->last_obj_cnt = count;