Commit 486ffc33 authored by Asbjørn Sloth Tønnesen's avatar Asbjørn Sloth Tønnesen Committed by Jakub Kicinski
Browse files

net: qede: flower: validate control flags 



This driver currently doesn't support any control flags.

Use flow_rule_match_has_control_flags() to check for control flags,
such as can be set through `tc flower ... ip_flags frag`.

In case any control flags are masked, flow_rule_match_has_control_flags()
sets a NL extended error message, and we return -EOPNOTSUPP.

Only compile-tested.

Signed-off-by: default avatarAsbjørn Sloth Tønnesen <ast@fiberby.net>
Reviewed-by: default avatarSimon Horman <horms@kernel.org>
Link: https://lore.kernel.org/r/20240511073705.230507-1-ast@fiberby.net


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent f4edb4de

drivers/net/ethernet/qlogic/qede/qede_filter.c

+3 −0
Original line number Diff line number Diff line
@@ -1848,6 +1848,9 @@ qede_parse_flow_attr(__be16 proto, struct flow_rule *rule, 
		return -EOPNOTSUPP;

	}



	if (flow_rule_match_has_control_flags(rule, extack))

		return -EOPNOTSUPP;



	if (proto != htons(ETH_P_IP) &&

	    proto != htons(ETH_P_IPV6)) {

		NL_SET_ERR_MSG_FMT_MOD(extack, "Unsupported proto=0x%x",