Commit 4886dd0a authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Martin K. Petersen
Browse files

scsi: aic94xx: Fix fall-through warnings for Clang 

In preparation to enable -Wimplicit-fallthrough for Clang, fix multiple
warnings by explicitly adding a couple of break and fallthrough statements
instead of just letting the code fall through to the next case.

Link: https://github.com/KSPP/linux/issues/115
Link: https://lore.kernel.org/r/9b58459045d303bbea0160f2e349f5799402a2bf.1605896059.git.gustavoars@kernel.org


Signed-off-by: default avatarGustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 995ae10f

drivers/scsi/aic94xx/aic94xx_scb.c

+2 −0
Original line number Diff line number Diff line
@@ -721,6 +721,7 @@ static void set_speed_mask(u8 *speed_mask, struct asd_phy_desc *pd) 
		fallthrough;

	case SAS_LINK_RATE_3_0_GBPS:

		*speed_mask |= SAS_SPEED_15_DIS;

		fallthrough;

	default:

	case SAS_LINK_RATE_1_5_GBPS:

		/* nothing to do */
@@ -739,6 +740,7 @@ static void set_speed_mask(u8 *speed_mask, struct asd_phy_desc *pd) 
	switch (pd->min_sata_lrate) {

	case SAS_LINK_RATE_3_0_GBPS:

		*speed_mask |= SATA_SPEED_15_DIS;

		fallthrough;

	default:

	case SAS_LINK_RATE_1_5_GBPS:

		/* nothing to do */

drivers/scsi/aic94xx/aic94xx_task.c

+2 −0
Original line number Diff line number Diff line
@@ -315,6 +315,7 @@ static void asd_task_tasklet_complete(struct asd_ascb *ascb, 
		break;

	case SAS_PROTOCOL_SSP:

		asd_unbuild_ssp_ascb(ascb);

		break;

	default:

		break;

	}
@@ -609,6 +610,7 @@ int asd_execute_task(struct sas_task *task, gfp_t gfp_flags) 
				break;

			case SAS_PROTOCOL_SSP:

				asd_unbuild_ssp_ascb(a);

				break;

			default:

				break;

			}