Unverified Commit 488954ca authored by Nathan Chancellor's avatar Nathan Chancellor
Browse files

powerpc: Drop unnecessary initializations in __copy_inst_from_kernel_nofault() 



Now that the minimum supported version of LLVM for building the kernel
has been bumped to 15.0.0, the zero initializations of val and suffix
added by commit 0d76914a ("powerpc/inst: Optimise
copy_inst_from_kernel_nofault()") to avoid a bogus case of
-Wuninitialized can be dropped because the preprocessor condition is
always false.

Reviewed-by: default avatarKees Cook <kees@kernel.org>
Reviewed-by: default avatarChristophe Leroy <christophe.leroy@csgroup.eu>
Link: https://lore.kernel.org/r/20250821-bump-min-llvm-ver-15-v2-6-635f3294e5f0@kernel.org


Signed-off-by: default avatarNathan Chancellor <nathan@kernel.org>
parent e633c2e7

arch/powerpc/include/asm/inst.h

+0 −4
Original line number Diff line number Diff line
@@ -143,10 +143,6 @@ static inline int __copy_inst_from_kernel_nofault(ppc_inst_t *inst, u32 *src) 
{

	unsigned int val, suffix;



/* See https://github.com/ClangBuiltLinux/linux/issues/1521 */

#if defined(CONFIG_CC_IS_CLANG) && CONFIG_CLANG_VERSION < 140000

	val = suffix = 0;

#endif

	__get_kernel_nofault(&val, src, u32, Efault);

	if (IS_ENABLED(CONFIG_PPC64) && get_op(val) == OP_PREFIX) {

		__get_kernel_nofault(&suffix, src + 1, u32, Efault);