Commit 48bdc8ec authored by Jens Axboe's avatar Jens Axboe
Browse files

[LIBATA] Blacklist certain Maxtor firmware revisions for FUA support 



It looks like they are either discarding or corrupting data when the FUA
command is used, bad.

Signed-off-by: default avatarJens Axboe <axboe@suse.de>
parent dfcd77d1

drivers/scsi/libata-scsi.c

+26 −1
Original line number Diff line number Diff line
@@ -1700,6 +1700,31 @@ static unsigned int ata_msense_rw_recovery(u8 **ptr_io, const u8 *last) 
	return sizeof(def_rw_recovery_mpage);

}



/*

 * We can turn this into a real blacklist if it's needed, for now just

 * blacklist any Maxtor BANC1G10 revision firmware

 */

static int ata_dev_supports_fua(u16 *id)

{

	unsigned char model[41], fw[9];



	if (!ata_id_has_fua(id))

		return 0;



	model[40] = '\0';

	fw[8] = '\0';



	ata_dev_id_string(id, model, ATA_ID_PROD_OFS, sizeof(model) - 1);

	ata_dev_id_string(id, fw, ATA_ID_FW_REV_OFS, sizeof(fw) - 1);



	if (strncmp(model, "Maxtor", 6))

		return 1;

	if (strncmp(fw, "BANC1G10", 8))

		return 1;



	return 0; /* blacklisted */

}



/**

 *	ata_scsiop_mode_sense - Simulate MODE SENSE 6, 10 commands

 *	@args: device IDENTIFY data / SCSI command of interest.
@@ -1797,7 +1822,7 @@ unsigned int ata_scsiop_mode_sense(struct ata_scsi_args *args, u8 *rbuf, 
		return 0;



	dpofua = 0;

	if (ata_id_has_fua(args->id) && dev->flags & ATA_DFLAG_LBA48 &&

	if (ata_dev_supports_fua(args->id) && dev->flags & ATA_DFLAG_LBA48 &&

	    (!(dev->flags & ATA_DFLAG_PIO) || dev->multi_count))

		dpofua = 1 << 4;