Commit 48d45fac authored Oct 31, 2023 by Jacek Lawrynowicz

accel/ivpu: Remove support for uncached buffers



Usages of DRM_IVPU_BO_UNCACHED should be replaced by DRM_IVPU_BO_WC.
There is no functional benefit from DRM_IVPU_BO_UNCACHED if these
buffers are never mapped to host VM.

This allows to cut the buffer handling code in the kernel driver
by half.

Usage of DRM_IVPU_BO_UNCACHED buffers was removed from user-space
driver and will not be part of first UMD release.

Signed-off-by: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231031073156.1301669-4-stanislaw.gruszka@linux.intel.com

parent 48aea7f2

drivers/accel/ivpu/ivpu_fw.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -286,7 +286,7 @@ static int ivpu_fw_mem_init(struct ivpu_device *vdev)

		if (fw->shave_nn_size) {
		fw->mem_shave_nn = ivpu_bo_alloc_internal(vdev, vdev->hw->ranges.shave.start,
		fw->shave_nn_size, DRM_IVPU_BO_UNCACHED);
		fw->shave_nn_size, DRM_IVPU_BO_WC);
		if (!fw->mem_shave_nn) {
		ivpu_err(vdev, "Failed to allocate shavenn buffer\n");
		ret = -ENOMEM;

drivers/accel/ivpu/ivpu_gem.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -89,8 +89,6 @@ static int __must_check shmem_alloc_pages_locked(struct ivpu_bo *bo)

		if (bo->flags & DRM_IVPU_BO_WC)
		set_pages_array_wc(pages, npages);
		else if (bo->flags & DRM_IVPU_BO_UNCACHED)
		set_pages_array_uc(pages, npages);

		bo->pages = pages;
		return 0;
		@@ -366,7 +364,6 @@ ivpu_bo_alloc(struct ivpu_device *vdev, u64 size, u32 flags, const struct ivpu_b

		switch (flags & DRM_IVPU_BO_CACHE_MASK) {
		case DRM_IVPU_BO_CACHED:
		case DRM_IVPU_BO_UNCACHED:
		case DRM_IVPU_BO_WC:
		break;
		default:

include/uapi/drm/ivpu_accel.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -196,7 +196,7 @@ struct drm_ivpu_bo_create {
		*
		* %DRM_IVPU_BO_UNCACHED:
		*
		* Allocated BO will not be cached on host side nor snooped on the VPU side.
		* Not supported. Use DRM_IVPU_BO_WC instead.
		*
		* %DRM_IVPU_BO_WC:
		*