Commit 48f1bbaf authored by Josh Poimboeuf's avatar Josh Poimboeuf
Browse files

objtool: Avoid emptying lists for duplicate sections 



When a to-be-created section already exists, there's no point in
emptying the various lists if their respective sections already exist.
In fact it's better to leave them intact as they might get used later.

Acked-by: default avatarPetr Mladek <pmladek@suse.com>
Tested-by: default avatarJoe Lawrence <joe.lawrence@redhat.com>
Signed-off-by: default avatarJosh Poimboeuf <jpoimboe@kernel.org>
parent a040ab73

tools/objtool/check.c

+0 −4
Original line number Diff line number Diff line
@@ -635,7 +635,6 @@ static int create_static_call_sections(struct objtool_file *file) 


	sec = find_section_by_name(file->elf, ".static_call_sites");

	if (sec) {

		INIT_LIST_HEAD(&file->static_call_list);

		WARN("file already has .static_call_sites section, skipping");

		return 0;

	}
@@ -851,7 +850,6 @@ static int create_cfi_sections(struct objtool_file *file) 


	sec = find_section_by_name(file->elf, ".cfi_sites");

	if (sec) {

		INIT_LIST_HEAD(&file->call_list);

		WARN("file already has .cfi_sites section, skipping");

		return 0;

	}
@@ -900,7 +898,6 @@ static int create_mcount_loc_sections(struct objtool_file *file) 


	sec = find_section_by_name(file->elf, "__mcount_loc");

	if (sec) {

		INIT_LIST_HEAD(&file->mcount_loc_list);

		WARN("file already has __mcount_loc section, skipping");

		return 0;

	}
@@ -945,7 +942,6 @@ static int create_direct_call_sections(struct objtool_file *file) 


	sec = find_section_by_name(file->elf, ".call_sites");

	if (sec) {

		INIT_LIST_HEAD(&file->call_list);

		WARN("file already has .call_sites section, skipping");

		return 0;

	}