Unverified Commit 490e6c9b authored Apr 26, 2024 by Yong Zhi Committed by Mark Brown Apr 30, 2024

ASoC: SOF: topology: remove incorrect widget id in error message

In sof_widget_ready() function, the shift field of
struct snd_soc_tplg_dapm_widget is incorrectly used to print
widget id in dev_err(scomp->dev, "error: failed to add widget id %d ..",
this patch removes the useless tw->shift from the error output.

Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Signed-off-by: Yong Zhi <yong.zhi@intel.com>
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20240426153902.39560-3-pierre-louis.bossart@linux.intel.com

Signed-off-by: Mark Brown <broonie@kernel.org>

parent b32487ca

sound/soc/sof/topology.c

+3 −4

Original line number	Diff line number	Diff line
		@@ -1531,9 +1531,8 @@ static int sof_widget_ready(struct snd_soc_component *scomp, int index,
		/* check token parsing reply */
		if (ret < 0) {
		dev_err(scomp->dev,
		"error: failed to add widget id %d type %d name : %s stream %s\n",
		tw->shift, swidget->id, tw->name,
		strnlen(tw->sname, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) > 0
		"failed to add widget type %d name : %s stream %s\n",
		swidget->id, tw->name, strnlen(tw->sname, SNDRV_CTL_ELEM_ID_NAME_MAXLEN) > 0
		? tw->sname : "none");
		goto widget_free;
		}