Commit 491254ff authored by Ben Skeggs's avatar Ben Skeggs Committed by Danilo Krummrich
Browse files

drm/nouveau/nvif: fix null ptr deref on pre-fermi boards 



Check that gpfifo.post() exists before trying to call it.

Fixes: 862450a8 ("drm/nouveau/gf100-: track chan progress with non-WFI semaphore release")
Reported-by: default avatarJamie Heilman <jamie@audible.transient.net>
Closes: https://lore.kernel.org/lkml/aElJIo9_Se6tAR1a@audible.transient.net/


Reported-by: default avatarRui Salvaterra <rsalvaterra@gmail.com>
Closes: https://lore.kernel.org/all/CALjTZvZgH0N43rMTcZiDVSX93PFL680hsYPwtp8=Ja1OWPvZ1A@mail.gmail.com/


Tested-by: default avatarRui Salvaterra <rsalvaterra@gmail.com>
Signed-off-by: default avatarBen Skeggs <bskeggs@nvidia.com>
Link: https://lore.kernel.org/r/20250714025923.29591-1-bskeggs@nvidia.com


Signed-off-by: default avatarDanilo Krummrich <dakr@kernel.org>
parent 1918e79b

drivers/gpu/drm/nouveau/nvif/chan.c

+3 −0
Original line number Diff line number Diff line
@@ -39,6 +39,9 @@ nvif_chan_gpfifo_post(struct nvif_chan *chan) 
	const u32 pbptr = (chan->push.cur - map) + chan->func->gpfifo.post_size;

	const u32 gpptr = (chan->gpfifo.cur + 1) & chan->gpfifo.max;



	if (!chan->func->gpfifo.post)

		return 0;



	return chan->func->gpfifo.post(chan, gpptr, pbptr);

}