Commit 4914d67d authored by Johan Hovold's avatar Johan Hovold Committed by Vinod Koul
Browse files

phy: ti: gmii-sel: fix regmap leak on probe failure 



The mmio regmap that may be allocated during probe is never freed.

Switch to using the device managed allocator so that the regmap is
released on probe failures (e.g. probe deferral) and on driver unbind.

Fixes: 5ab90f40 ("phy: ti: gmii-sel: Do not use syscon helper to build regmap")
Cc: stable@vger.kernel.org	# 6.14
Cc: Andrew Davis <afd@ti.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Acked-by: default avatarAndrew Davis <afd@ti.com>
Link: https://patch.msgid.link/20251127134834.2030-1-johan@kernel.org


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent d543d3eb

drivers/phy/ti/phy-gmii-sel.c

+1 −1
Original line number Diff line number Diff line
@@ -512,7 +512,7 @@ static int phy_gmii_sel_probe(struct platform_device *pdev) 
			return dev_err_probe(dev, PTR_ERR(base),

					     "failed to get base memory resource\n");



		priv->regmap = regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_cfg);

		priv->regmap = devm_regmap_init_mmio(dev, base, &phy_gmii_sel_regmap_cfg);

		if (IS_ERR(priv->regmap))

			return dev_err_probe(dev, PTR_ERR(priv->regmap),

					     "Failed to get syscon\n");