Commit 4920ee6d authored by Christian Marangi's avatar Christian Marangi Committed by Chanwoo Choi
Browse files

PM / devfreq: Convert to use sysfs_emit_at() API 

Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Link: https://lore.kernel.org/all/20231024183016.14648-3-ansuelsmth@gmail.com/


Signed-off-by: default avatarChristian Marangi <ansuelsmth@gmail.com>
Signed-off-by: default avatarChanwoo Choi <cw00.choi@samsung.com>
parent 08e23d05

drivers/devfreq/devfreq.c

+17 −20
Original line number Diff line number Diff line
@@ -1697,7 +1697,7 @@ static ssize_t trans_stat_show(struct device *dev, 
	max_state = df->max_state;



	if (max_state == 0)

		return scnprintf(buf, PAGE_SIZE, "Not Supported.\n");

		return sysfs_emit(buf, "Not Supported.\n");



	mutex_lock(&df->lock);

	if (!df->stop_polling &&
@@ -1707,47 +1707,44 @@ static ssize_t trans_stat_show(struct device *dev, 
	}

	mutex_unlock(&df->lock);



	len += scnprintf(buf + len, PAGE_SIZE - len, "     From  :   To\n");

	len += scnprintf(buf + len, PAGE_SIZE - len, "           :");

	len += sysfs_emit_at(buf, len, "     From  :   To\n");

	len += sysfs_emit_at(buf, len, "           :");

	for (i = 0; i < max_state; i++) {

		if (len >= PAGE_SIZE - 1)

			break;

		len += scnprintf(buf + len, PAGE_SIZE - len, "%10lu",

		len += sysfs_emit_at(buf, len, "%10lu",

				     df->freq_table[i]);

	}



	if (len >= PAGE_SIZE - 1)

		return PAGE_SIZE - 1;



	len += scnprintf(buf + len, PAGE_SIZE - len, "   time(ms)\n");

	len += sysfs_emit_at(buf, len, "   time(ms)\n");



	for (i = 0; i < max_state; i++) {

		if (len >= PAGE_SIZE - 1)

			break;

		if (df->freq_table[i] == df->previous_freq)

			len += scnprintf(buf + len, PAGE_SIZE - len, "*");

		if (df->freq_table[2] == df->previous_freq)

			len += sysfs_emit_at(buf, len, "*");

		else

			len += scnprintf(buf + len, PAGE_SIZE - len, " ");

			len += sysfs_emit_at(buf, len, " ");

		if (len >= PAGE_SIZE - 1)

			break;



		len += scnprintf(buf + len, PAGE_SIZE - len, "%10lu:",

				 df->freq_table[i]);

		len += sysfs_emit_at(buf, len, "%10lu:", df->freq_table[i]);

		for (j = 0; j < max_state; j++) {

			if (len >= PAGE_SIZE - 1)

				break;

			len += scnprintf(buf + len, PAGE_SIZE - len, "%10u",

			len += sysfs_emit_at(buf, len, "%10u",

				df->stats.trans_table[(i * max_state) + j]);

		}

		if (len >= PAGE_SIZE - 1)

			break;

		len += scnprintf(buf + len, PAGE_SIZE - len, "%10llu\n", (u64)

		len += sysfs_emit_at(buf, len, "%10llu\n", (u64)

				     jiffies64_to_msecs(df->stats.time_in_state[i]));

	}



	if (len < PAGE_SIZE - 1)

		len += scnprintf(buf + len, PAGE_SIZE - len, "Total transition : %u\n",

		len += sysfs_emit_at(buf, len, "Total transition : %u\n",

				     df->stats.total_trans);



	if (len >= PAGE_SIZE - 1) {

		pr_warn_once("devfreq transition table exceeds PAGE_SIZE. Disabling\n");

		return -EFBIG;