Commit 493d0856 authored by Yang Li's avatar Yang Li Committed by Greg Kroah-Hartman
Browse files

usb: typec: tcpm: turn tcpm_ams_finish into void function 



This function always return '0' and no callers use the return value.
So make it a void function.

This eliminates the following coccicheck warning:
./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret".
Return "0" on line 794

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Reviewed-by: default avatarHeikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Link: https://lore.kernel.org/r/1615185330-118246-1-git-send-email-yang.lee@linux.alibaba.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 19c234a1

drivers/usb/typec/tcpm/tcpm.c

+1 −5
Original line number Diff line number Diff line
@@ -780,10 +780,8 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port *port) 
	return TYPEC_CC_RP_DEF;

}



static int tcpm_ams_finish(struct tcpm_port *port)

static void tcpm_ams_finish(struct tcpm_port *port)

{

	int ret = 0;



	tcpm_log(port, "AMS %s finished", tcpm_ams_str[port->ams]);



	if (port->pd_capable && port->pwr_role == TYPEC_SOURCE) {
@@ -797,8 +795,6 @@ static int tcpm_ams_finish(struct tcpm_port *port) 


	port->in_ams = false;

	port->ams = NONE_AMS;



	return ret;

}



static int tcpm_pd_transmit(struct tcpm_port *port,