Commit 494fc029 authored Jan 20, 2026 by Marc Kleine-Budde

can: gs_usb: gs_usb_receive_bulk_callback(): fix error message

Sinc commit 79a6d1bf ("can: gs_usb: gs_usb_receive_bulk_callback():
unanchor URL on usb_submit_urb() error") a failing resubmit URB will print
an info message.

In the case of a short read where netdev has not yet been assigned,
initialize as NULL to avoid dereferencing an undefined value. Also report
the error value of the failed resubmit.

Fixes: 79a6d1bf ("can: gs_usb: gs_usb_receive_bulk_callback(): unanchor URL on usb_submit_urb() error")
Reported-by: Jakub Kicinski <kuba@kernel.org>
Closes: https://lore.kernel.org/all/20260119181904.1209979-1-kuba@kernel.org/
Link: https://patch.msgid.link/20260120-gs_usb-fix-error-message-v1-1-6be04de572bc@pengutronix.de

Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 0baa4d31

drivers/net/can/usb/gs_usb.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -610,7 +610,7 @@ static void gs_usb_receive_bulk_callback(struct urb *urb)
		{
		struct gs_usb *parent = urb->context;
		struct gs_can *dev;
		struct net_device *netdev;
		struct net_device *netdev = NULL;
		int rc;
		struct net_device_stats *stats;
		struct gs_host_frame *hf = urb->transfer_buffer;
		@@ -768,7 +768,7 @@ static void gs_usb_receive_bulk_callback(struct urb *urb)
		}
		} else if (rc != -ESHUTDOWN && net_ratelimit()) {
		netdev_info(netdev, "failed to re-submit IN URB: %pe\n",
		ERR_PTR(urb->status));
		ERR_PTR(rc));
		}
		}