Commit 495b1904 authored by Srinivasan Shanmugam's avatar Srinivasan Shanmugam Committed by Alex Deucher
Browse files

drm/amdgpu/acpi: Reduce amdgpu_acpi_detect stack usage 



amdgpu_acpi_detect() calls some helper functions it calls have large
local structures.  When the compiler inlines these helpers, their local
data adds to the amdgpu_acpi_detect() stack frame.

Mark the helpers with noinline_for_stack:
- amdgpu_atif_verify_interface()
- amdgpu_atif_get_notification_params()
- amdgpu_atif_query_backlight_caps()
- amdgpu_atcs_verify_interface()
- amdgpu_acpi_enumerate_xcc()

This keeps the large temporary objects inside the helper’s own stack
frame instead of being inlined into the caller, preventing the caller
from growing beyond the stack limit.

Fixes the below with gcc W=1:
drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c:1403:6: warning: stack frame size (1688) exceeds limit (1024) in 'amdgpu_acpi_detect' [-Wframe-larger-than]

Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Christian König <christian.koenig@amd.com>
Signed-off-by: default avatarSrinivasan Shanmugam <srinivasan.shanmugam@amd.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 35bb80e6

drivers/gpu/drm/amd/amdgpu/amdgpu_acpi.c

+10 −5
Original line number Diff line number Diff line
@@ -241,7 +241,8 @@ static void amdgpu_atif_parse_functions(struct amdgpu_atif_functions *f, u32 mas 
 * (all asics).

 * returns 0 on success, error on failure.

 */

static int amdgpu_atif_verify_interface(struct amdgpu_atif *atif)

static noinline_for_stack

int amdgpu_atif_verify_interface(struct amdgpu_atif *atif)

{

	union acpi_object *info;

	struct atif_verify_interface output;
@@ -286,7 +287,8 @@ static int amdgpu_atif_verify_interface(struct amdgpu_atif *atif) 
 * where n is specified in the result if a notifier is used.

 * Returns 0 on success, error on failure.

 */

static int amdgpu_atif_get_notification_params(struct amdgpu_atif *atif)

static noinline_for_stack

int amdgpu_atif_get_notification_params(struct amdgpu_atif *atif)

{

	union acpi_object *info;

	struct amdgpu_atif_notification_cfg *n = &atif->notification_cfg;
@@ -354,7 +356,8 @@ static int amdgpu_atif_get_notification_params(struct amdgpu_atif *atif) 
 *

 * Returns 0 on success, error on failure.

 */

static int amdgpu_atif_query_backlight_caps(struct amdgpu_atif *atif)

static noinline_for_stack

int amdgpu_atif_query_backlight_caps(struct amdgpu_atif *atif)

{

	union acpi_object *info;

	struct atif_qbtc_output characteristics;
@@ -600,7 +603,8 @@ static void amdgpu_atcs_parse_functions(struct amdgpu_atcs_functions *f, u32 mas 
 * (all asics).

 * returns 0 on success, error on failure.

 */

static int amdgpu_atcs_verify_interface(struct amdgpu_atcs *atcs)

static noinline_for_stack

int amdgpu_atcs_verify_interface(struct amdgpu_atcs *atcs)

{

	union acpi_object *info;

	struct atcs_verify_interface output;
@@ -1089,7 +1093,8 @@ static int amdgpu_acpi_get_xcc_info(struct amdgpu_acpi_xcc_info *xcc_info, 
	return ret;

}



static int amdgpu_acpi_enumerate_xcc(void)

static noinline_for_stack

int amdgpu_acpi_enumerate_xcc(void)

{

	struct amdgpu_acpi_dev_info *dev_info = NULL;

	struct amdgpu_acpi_xcc_info *xcc_info;