Unverified Commit 496ba79b authored by Felix Gu's avatar Felix Gu Committed by Mark Brown
Browse files

spi: mtk-snfi: Fix resource leak in mtk_snand_read_page_cache() 



When DMA read times out in mtk_snand_read_page_cache(), the original code
erroneously jumped to cleanup label which skips DMA unmapping and ECC
disable, causing a resource leak.

Fixes: 764f1b74 ("spi: add driver for MTK SPI NAND Flash Interface")
Signed-off-by: default avatarFelix Gu <ustc.gu@gmail.com>
Link: https://patch.msgid.link/20260510-snfi-v1-1-bc375cf1af8e@gmail.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 5e121a81

drivers/spi/spi-mtk-snfi.c

+1 −1
Original line number Diff line number Diff line
@@ -961,7 +961,7 @@ static int mtk_snand_read_page_cache(struct mtk_snand *snf, 
		    &snf->op_done, usecs_to_jiffies(SNFI_POLL_INTERVAL))) {

		dev_err(snf->dev, "DMA timed out for reading from cache.\n");

		ret = -ETIMEDOUT;

		goto cleanup;

		goto cleanup2;

	}



	// Wait for BUS_SEC_CNTR returning expected value