Commit 49995681 authored by Guixin Liu's avatar Guixin Liu Committed by Keith Busch
Browse files

nvme-fabrics: check max outstanding commands 



Maxcmd is mandatory for fabrics, check it early to identify the root
cause instead of waiting for it to propagate to "sqsize" and "allocing
queue".

By the way, change nvme_check_ctrl_fabric_info() to
nvmf_validate_identify_ctrl().

Reviewed-by: default avatarChaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: default avatarGuixin Liu <kanie@linux.alibaba.com>
Signed-off-by: default avatarKeith Busch <kbusch@kernel.org>
parent f096ba32

drivers/nvme/host/core.c

+5 −0
Original line number Diff line number Diff line
@@ -3119,6 +3119,11 @@ static int nvme_check_ctrl_fabric_info(struct nvme_ctrl *ctrl, struct nvme_id_ct 
		return -EINVAL;

	}



	if (!ctrl->maxcmd) {

		dev_err(ctrl->device, "Maximum outstanding commands is 0\n");

		return -EINVAL;

	}



	return 0;

}