Commit 49c1364c authored by Steven Rostedt's avatar Steven Rostedt Committed by Steven Rostedt (Google)
Browse files

tracing: Remove unused variable in tracing_trace_options_show() 

The flags and opts used in tracing_trace_options_show() now come directly
from the trace array "current_trace_flags" and not the current_trace. The
variable "trace" was still being assigned to tr->current_trace but never
used. This caused a warning in clang.

Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/20251117120637.43ef995d@gandalf.local.home


Reported-by: default avatarAndy Shevchenko <andriy.shevchenko@intel.com>
Tested-by: default avatarAndy Shevchenko <andriy.shevchenko@intel.com>
Closes: https://lore.kernel.org/all/aRtHWXzYa8ijUIDa@black.igk.intel.com/


Fixes: 428add55 ("tracing: Have tracer option be instance specific")
Signed-off-by: default avatarSteven Rostedt (Google) <rostedt@goodmis.org>
parent ac87b220

kernel/trace/trace.c

+0 −3
Original line number Diff line number Diff line
@@ -5167,7 +5167,6 @@ static int tracing_trace_options_show(struct seq_file *m, void *v) 
	struct tracer_opt *trace_opts;

	struct trace_array *tr = m->private;

	struct tracer_flags *flags;

	struct tracer *trace;

	u32 tracer_flags;

	int i;
@@ -5184,8 +5183,6 @@ static int tracing_trace_options_show(struct seq_file *m, void *v) 
	if (!flags || !flags->opts)

		return 0;



	trace = tr->current_trace;



	tracer_flags = flags->val;

	trace_opts = flags->opts;