Commit 49db61c2 authored by Florian Larysch's avatar Florian Larysch Committed by Jakub Kicinski
Browse files

net: phy: micrel: fix KSZ8081/KSZ8091 cable test 



Commit 21b688da ("net: phy: micrel: Cable Diag feature for lan8814
phy") introduced cable_test support for the LAN8814 that reuses parts of
the KSZ886x logic and introduced the cable_diag_reg and pair_mask
parameters to account for differences between those chips.

However, it did not update the ksz8081_type struct, so those members are
now 0, causing no pairs to be tested in ksz886x_cable_test_get_status
and ksz886x_cable_test_wait_for_completion to poll the wrong register
for the affected PHYs (Basic Control/Reset, which is 0 in normal
operation) and exit immediately.

Fix this by setting both struct members accordingly.

Fixes: 21b688da ("net: phy: micrel: Cable Diag feature for lan8814 phy")
Cc: stable@vger.kernel.org
Signed-off-by: default avatarFlorian Larysch <fl@n621.de>
Link: https://patch.msgid.link/20250723222250.13960-1-fl@n621.de


Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 1bbb76a8

drivers/net/phy/micrel.c

+2 −0
Original line number Diff line number Diff line
@@ -472,6 +472,8 @@ static const struct kszphy_type ksz8051_type = { 


static const struct kszphy_type ksz8081_type = {

	.led_mode_reg		= MII_KSZPHY_CTRL_2,

	.cable_diag_reg		= KSZ8081_LMD,

	.pair_mask		= KSZPHY_WIRE_PAIR_MASK,

	.has_broadcast_disable	= true,

	.has_nand_tree_disable	= true,

	.has_rmii_ref_clk_sel	= true,