Commit 4a36b339 authored by Jani Nikula's avatar Jani Nikula
Browse files

drm/xe/fbdev: use the same 64-byte stride alignment as i915 

For reasons unknown, xe uses XE_PAGE_SIZE alignment for
stride. Presumably it's just a confusion between stride alignment and bo
allocation size alignment. Switch to 64 byte alignment to, uh, align
with i915.

This will also be helpful in deduplicating and unifying the xe and i915
framebuffer allocation.

Link: https://lore.kernel.org/r/aLqsC87Ol_zCXOkN@intel.com


Suggested-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: default avatarVille Syrjälä <ville.syrjala@linux.intel.com>
Link: https://lore.kernel.org/r/7f4972104de8b179d5724ae83892ee294d3f3fd3.1758184771.git.jani.nikula@intel.com


Signed-off-by: default avatarJani Nikula <jani.nikula@intel.com>
parent a58b9e3d

drivers/gpu/drm/xe/display/intel_fbdev_fb.c

+1 −1
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ struct intel_framebuffer *intel_fbdev_fb_alloc(struct drm_fb_helper *helper, 
	mode_cmd.height = sizes->surface_height;



	mode_cmd.pitches[0] = ALIGN(mode_cmd.width *

				    DIV_ROUND_UP(sizes->surface_bpp, 8), XE_PAGE_SIZE);

				    DIV_ROUND_UP(sizes->surface_bpp, 8), 64);

	mode_cmd.pixel_format = drm_mode_legacy_fb_format(sizes->surface_bpp,

							  sizes->surface_depth);